Repository navigation
Count qualifying comprehension elements without building a list - #38
Merged
Merged
Conversation
Specialize size() of unmapped list comprehensions to filtered COUNT(1), preserving null elements, duplicates, padding and input-row multiplicity. Keep mapped and pattern comprehensions on their existing path. Document the non-nullable Arrow count field and add focused plan/result tests plus a reference benchmark. Part of #18. Isolated Rust suite: 349 passed, one optional timing diagnostic ignored. Formatting, focused Ruff and strict docs passed. Python, benchmark and SF1 measurements pending; no performance claim. Submitted by David Hughes (@stugorf), with AI Collaboration.
Member
|
This change merged into an intermediate branch, not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Issue18. Proposed branch
codex/issue-18-curatedat4bc6eeae6a6f0c71bb23559b3c81387a49970836; actual comparison basecodex/issue-18-prerequisitesat07a0fa1246c1829f4184e7d33c5fa063a4a76f19(pagination90 plus alias-scope21).A direct
size([x IN values WHERE predicate])now counts the qualifying rows without collecting an intermediate list. The existing element stream, predicate and correlated EXISTS behavior remain responsible for membership and multiplicity. Empty/null lists produce zero; duplicate elements and duplicate outer rows retain their counts. Mapped comprehensions and pattern comprehensions keep normal list behavior.Validation
Head
4bc6eeae6a6f0c71bb23559b3c81387a49970836; frozen parent07a0fa1246c1829f4184e7d33c5fa063a4a76f19. Focused checks and regression details record commands, results, documentation and compatibility. The release receipt pins wheel/archive identity and 36 installed tests.Both complete workloads pass unchanged goldens in memory and lazy modes. Retained first-pass geometric mean speedups are below (greater than one is faster). Per-query results and paired investigations remain in the audit archive.
Measurements use the same Apple M4 Max (16 cores, 128 GiB), macOS 26.6.2 arm64 and Python 3.13.17, with Q30 revision
6260689and IC revisionc185123. Reproduction instructions pin settings, data checksums, locks and commands. The frozen main baseline is code-identical to current main90114f3; the equivalence check also verifies clean prospective main-target merges.Individual review gates pass under the recorded repeat/controlled-investigation rules. Initial failed measurements remain intact in the audit record.
User impact
Cardinality-only filtered comprehensions use existential counts without multiplying items by matching-edge count. Returned lists keep general planning. Null/empty/duplicate semantics and supported optimization shapes are documented.
Review ledger · Current contribution guide
Audit archive: 47,675,190 bytes; SHA-256
b3486fb30a34639c830b5d49353b3838f96369f95df959ac35f85511f7f8b2de. The small current-main supplement preserves the documentation update. Original absolute paths in receipts map to included records through the archive index.Submitted by David Hughes (@stugorf), with AI Collaboration.