Repository navigation
perf(csr): reuse filter columns during target materialization - #36
Merged
prrao87 merged 1 commit intoOct 26, 2026
Merged
Conversation
Member
|
This change merged into an intermediate branch, not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Addresses duplicate property reads in #16. Columns fetched for a pushed target predicate are filtered once and reused when projection also needs them. Remaining properties are fetched only for survivors. Reuse stays within one bounded output batch and its pinned snapshot; this adds no full-column cache, Python API or dependency. Existing projection pruning and Lance row sorting/deduplication retain their roles.
Real Arrow/Lance tests cover duplicate and out-of-order positions, null predicates, empty results, overlapping/disjoint/empty projections, reconstructed IDs and unused columns. A read-cell counter verifies six candidate ages plus four surviving names require ten cells, without repeated age or ID reads. Complete workspace tests/Clippy, 351 Python tests, lint/typing, strict docs, spelling and executable guides pass. The CSR guide and existing benchmark describe and exercise filter/projection reuse.
Validation
Head
447355dbaf90993d33926afc48ab6712e421505a; frozen parent1bf6d42141b9cc6ee1824d000f49cdc0ebd9d8fe. Focused checks and regression details record commands, results, documentation and compatibility. The release receipt pins wheel/archive identity and 159 installed tests.Both complete workloads pass unchanged goldens in memory and lazy modes. Retained first-pass geometric mean speedups are below (greater than one is faster). Per-query results and paired investigations remain in the audit archive.
Measurements use the same Apple M4 Max (16 cores, 128 GiB), macOS 26.6.2 arm64 and Python 3.13.17, with Q30 revision
6260689and IC revisionc185123. Reproduction instructions pin settings, data checksums, locks and commands. The frozen main baseline is code-identical to current main90114f3; the equivalence check also verifies clean prospective main-target merges.This is a coordinated draft. Preserve its frozen-head outcomes and apply the shared corrections in the qualified integration; changing the actual target requires requalification. The accepted combined engine source is
7d2ef3e; its current-main documentation merge is5fe24cd.User impact
Results and ordering are preserved while filter columns are reused within each output batch. There is no persistent property cache or Python API change. The CSR guide and existing benchmark cover the behavior.
Review ledger · Current contribution guide
Audit archive: 47,675,190 bytes; SHA-256
b3486fb30a34639c830b5d49353b3838f96369f95df959ac35f85511f7f8b2de. The small current-main supplement preserves the documentation update. Original absolute paths in receipts map to included records through the archive index.Submitted by David Hughes (@stugorf), with AI Collaboration.