Skip to content

fix: persist equity STOP submissions in the shared execution store - #106

Merged
felipecsl merged 1 commit into
mainfrom
fix/equity-stop-submission-record
Sep 28, 2026
Merged

felipecsl merged 1 commit into
mainfrom
fix/equity-stop-submission-record

Conversation

@felipecsl

Copy link
Copy Markdown
Member

Summary

equity submit could not submit a STOP order. The shared execution store checked single submission records against its own copy of the equity intent schema, and that copy accepted orderType: "LMT" only. For a STOP preview, the submission reservation threw a ZodError. That happens before the broker write, so no order was placed and the command failed.

  • canonicalEquityIntentSchema (LMT or STP) now lives in src/equities/equityOrder.ts. The equity service and the shared execution store both use this one schema. The LMT-only copy is removed.
  • equityOrder.ts has no runtime imports, so the move adds no import cycle.

Tests

  • New test: "the shared execution store persists an equity STOP submission". It failed before this fix with a ZodError from the store, and it passes now.
  • yarn check passes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-09-28T01:37:21.577765Z 93d43e0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@felipecsl
felipecsl merged commit 3366272 into main Sep 28, 2026
1 check passed
@felipecsl
felipecsl deleted the fix/equity-stop-submission-record branch September 28, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant