fix: persist equity STOP submissions in the shared execution store - #106
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
equity submitcould not submit a STOP order. The shared execution store checkedsinglesubmission records against its own copy of the equity intent schema, and that copy acceptedorderType: "LMT"only. For a STOP preview, the submission reservation threw aZodError. That happens before the broker write, so no order was placed and the command failed.canonicalEquityIntentSchema(LMT or STP) now lives insrc/equities/equityOrder.ts. The equity service and the shared execution store both use this one schema. The LMT-only copy is removed.equityOrder.tshas no runtime imports, so the move adds no import cycle.Tests
ZodErrorfrom the store, and it passes now.yarn checkpasses.