[hungpham10]

Tóm tắt

Mở rộng rerank Jev (TypeSafe SystemOne) từ codegraph_context sang symbol search và 3 tool document search. Stacked trên #59.

Thay đổi

codegraph_search_symbol

• Arg mới rerank = "none" | "jev" (default none).
• Pool = limit × 4, cap [jev] max_candidates (40) → model có lựa chọn rồi cắt về limit.
• Mỗi hit có match_score.probability; response có no_match + rerank { used, reason }.
• Chỉ trang đầu: offset > 0 hoặc có resume → lỗi rõ ràng (rerank phá tính ổn định phân trang). Binary rows giữ nguyên thứ tự.

Document search (graphdoc_search, graphdoc_search_value, graphdoc_search_struct)

• Cùng arg rerank. Khi bật, response thành { results, no_match, rerank }; khi tắt vẫn là array như cũ (không breaking).
• Candidate label: kind `key_path` in `doc_path`.
• Pool rộng hơn limit (search_value lấy thêm limit × 4; struct search rerank trên rows đã sort IDF).

Config [jev]

Key	Default	Ý nghĩa
doc_include_values	false	Đưa value của node vào mô tả option. Key một mình không phân biệt được (spec.replicas ở nhiều file); value giúp Jev chọn đúng nhưng tốn token theo số candidate
doc_value_chars	120	Cắt value còn bao nhiêu ký tự

Kiến trúc

• codegraph_context::rank() + RankOutcome dùng chung cho context / symbol / doc → không lặp logic fail-open.
• codegraph-api::search_symbol_reranked() giữ phần lọc binary/timing ở tầng API.

Fail-open

Jev tắt, thiếu token, timeout, 4xx, JSON lạ → giữ thứ tự cũ, rerank.used = false + reason. Không tool nào hỏng vì Jev.

Test

• MCP: rerank_tests.rs — candidate doc (doc_include_values on/off, cắt value), apply_doc_outcome (fail-open / no_match / sort + match_score), dispatch thật qua doc graph (array vs object), guard offset/resume cho symbol search.
• API: search_symbol_reranked với judge giả (đổi thứ tự, cắt theo limit, total gốc), no_match, fail-open khi jev tắt.
• Live #[ignore]: thêm case doc-node — chạy thật, Jev chọn đúng node nhờ value (id 2, p=0.81, none=0.05).

Verify

• cargo fmt --all -- --check ✅
• cargo clippy --workspace --all-targets -- -D warnings ✅
• cargo clippy -p codegraph-graph --features postgres,mysql,redis --tests -- -D warnings ✅
• cargo test --workspace ✅ (4 test storage::redis fail Connection refused — pre-existing, không có redis-server)
• cargo test -p codegraph-context --test jev_live -- --ignored ✅ (2/2 pass, gọi API thật)

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 548b7067-7250-45e5-b854-b2ba6e808cfe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov-commenter]

Codecov Report

❌ Patch coverage is 90.37657% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.28%. Comparing base (023644b) to head (ca08bbf).
⚠️ Report is 3 commits behind head on feat/jev-context-rerank.

Files with missing lines	Patch %	Lines
crates/codegraph-mcp/src/tools.rs	82.65%	30 Missing ⚠️
crates/codegraph-api/src/lib.rs	89.61%	8 Missing ⚠️
crates/codegraph-context/src/jev.rs	97.35%	4 Missing ⚠️
crates/codegraph-mcp/src/lib.rs	33.33%	4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (90.37%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@                     Coverage Diff                     @@
##           feat/jev-context-rerank      #60      +/-   ##
===========================================================
+ Coverage                    80.77%   81.28%   +0.51%     
===========================================================
  Files                          105      105              
  Lines                        30205    30561     +356     
===========================================================
+ Hits                         24398    24843     +445     
+ Misses                        5807     5718      -89     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[codspeed]

Merging this PR will not alter performance

1 warning

⚠️ 22 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 38 untouched benchmarks

---

_{Comparing feat/jev-rerank-search (c28291a) with feat/jev-context-rerank (677659e)}