Skip to content

fix(extract/config): render inline-table call in list_effect_rules - #53

Merged
hungpham10 merged 1 commit into
mainfrom
fix/render-inline-table-call
Oct 26, 2026
Merged

hungpham10 merged 1 commit into
mainfrom
fix/render-inline-table-call

Conversation

@hungpham10

Copy link
Copy Markdown
Owner

list_effect_rules read call via .as_table(), which only matches a standard table ([effect_rules.call]) — inline table call = { exact = "PG_TRY" } (the form users write in config.toml) was skipped, so codegraph_config_effects list showed an empty call.

Switch to .as_table_like() (accepts both Table and InlineTable) and add test effect_rule_list_renders_call covering inline-table rules.

Co-authored-by: CodeGraph agent

list_effect_rules read `call` via `.as_table()`, which only matches a
standard table ([effect_rules.call]) — inline table
`call = { exact = "PG_TRY" }` (the form users write in config.toml) was
skipped, so `codegraph_config_effects list` showed an empty call.

Switch to `.as_table_like()` (accepts both Table and InlineTable) and
add test effect_rule_list_renders_call covering inline-table rules.

Co-authored-by: CodeGraph agent
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cb841456-8d8f-4b05-8611-f69de4201144
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hungpham10
hungpham10 merged commit ccd3705 into main Oct 26, 2026
22 checks passed
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.04%. Comparing base (f57ccf9) to head (037a2d7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   80.05%   80.04%   -0.02%     
==========================================
  Files          97       97              
  Lines       28765    28765              
==========================================
- Hits        23029    23026       -3     
- Misses       5736     5739       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hungpham10
hungpham10 deleted the fix/render-inline-table-call branch October 26, 2026 08:53
@codspeed

codspeed Bot commented Oct 26, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 22 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 38 untouched benchmarks


Comparing fix/render-inline-table-call (037a2d7) with main (f57ccf9)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants