fix: resolve SamplingMetric string normalize argument - #1366
Open
Abelo9996 wants to merge 1 commit into
Open
Conversation
inspect.getmembers() returns a list of (name, function) tuples, but SamplingMetric.__init__ treated it as a dict, so a string normalize argument was compared against tuples (always False) and every valid normalizer name raised "Unknown normalization function". Build a dict from the members so names resolve to functions. Add unit tests for the string, callable, unknown-name and None cases. Fixes huggingface#1365
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the string form of the
normalizeargument on sampling metrics (AvgAtN,MajAtN,PassAtK,GPassAtK).Why
SamplingMetric.__init__resolved a stringnormalizeviainspect.getmembers(...), which returns a list of(name, function)tuples, but treated it as a dict. Sonormalize in allowed_normalizationscompared the string against tuples and was alwaysFalse, and every valid normalizer name raisedValueError: Unknown normalization function. A standalone repro is in #1365.Change
normalize in allowed_normalizationschecks names andallowed_normalizations[normalize]returns the function.Fixes #1365