Add the DynamicInstructions builder - #293
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Composition can discard meaningful whitespace, and collection resolution introduces quadratic copying overhead.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds the Foundation Models 27-shaped dynamic-instructions API. Session integration is deferred to the next PR.
Changes:
- Adds composable instructions and tools with conditionals, collections, and type erasure.
- Adds resolution tests for composition, empty content, and repeated body evaluation.
| File | Description |
|---|---|
| Tests/AnyLanguageModelTests/DynamicInstructionsBuilderTests.swift | Tests builder composition and resolution. |
| Sources/AnyLanguageModel/DynamicInstructions.swift | Defines the builder, supporting types, and internal resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the second of three that bring in #273 by @qoli. It adds the
DynamicInstructionsprotocol and its result builder, following Foundation Models 27:DynamicInstructionsBuilder,AnyDynamicInstructions,TupleDynamicInstructions,ConditionalDynamicInstructions,EmptyDynamicInstructions, andDynamicInstructionsForEach, with instructions and tools as building blocks. Nothing uses it yet; the next PR adds sessions that resolve dynamic instructions before each request.The builder is @qoli's, unchanged except for documentation notes that mark it as following Foundation Models 27.