Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The deprecated declarations are removed consistently, remaining references are updated, and documented defaults are preserved.
Review effort: Balanced
Findings: None
What changed in this PR
Removes APIs deprecated ahead of 1.0 while preserving default Gemini and llama.cpp behavior.
Changes:
- Removes deprecated error alias and legacy Gemini/Llama APIs.
- Updates tests to use replacement APIs.
- Refreshes dependency resolution pins.
| File | Description |
|---|---|
Sources/AnyLanguageModel/Generable.swift |
Removes deprecated error alias. |
Sources/AnyLanguageModel/Models/GeminiLanguageModel.swift |
Removes legacy configuration APIs and retains defaults. |
Sources/AnyLanguageModel/Models/LlamaLanguageModel.swift |
Removes legacy initializer and properties. |
Tests/AnyLanguageModelTests/GeneratedContentErrorTests.swift |
Tests the current error type directly. |
Tests/AnyLanguageModelTests/LlamaLanguageModelTests.swift |
Removes tests for deleted APIs. |
Package.resolved |
Adds resolved optional dependency pins. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the 16 declarations that were deprecated ahead of 1.0 (#210):
GeneratedContentConversionError, which was renamed toGeneratedContentErrorLlamaLanguageModel.init(modelPath:contextSize:batchSize:threads:seed:temperature:topK:topP:repeatPenalty:repeatLastN:)and the nine matching properties, whichGenerationOptions[custom: LlamaLanguageModel.self]replacedGeminiLanguageModel.init(baseURL:apiKey:apiVersion:model:thinking:serverTools:session:), thethinkingandserverToolsproperties, and theThinkingandServerTooltypealiases, whichGenerationOptions[custom: GeminiLanguageModel.self]and the types inGeminiLanguageModel.CustomGenerationOptionsreplacedRequests that don't set custom options behave as before: Gemini still defaults to thinking disabled and no server tools, and llama.cpp uses the same defaults.