Bound MLX test responses - #285
Merged
Merged
Conversation
Text generation has no default token limit, and nine MLX tests didn't set one. One full-suite run hung for more than 11 minutes in token generation. Give those tests a 512-token limit, like tokenUsageSurvivesToolStopAndFailure.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes consistently bound previously unlimited generation paths without altering tested behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Bounds MLX test generation to prevent non-terminating responses from stalling the suite.
Changes:
- Adds shared 512-token generation options.
- Applies limits to text, tool-calling, multimodal, and cache tests.
| File | Description |
|---|---|
Tests/AnyLanguageModelTests/MLXLanguageModelTests.swift |
Adds bounded response options to MLX integration tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.