Skip to content

feat Enabled read/write lock for GitHubSanityCachedValue #2201

Merged
bitwiseman merged 12 commits into
hub4j:mainfrom
ravikumar2026:feature/enableLock
Jul 11, 2026
Merged

feat Enabled read/write lock for GitHubSanityCachedValue #2201
bitwiseman merged 12 commits into
hub4j:mainfrom
ravikumar2026:feature/enableLock

Conversation

@ravikumar2026

Copy link
Copy Markdown
Contributor

Description

feat Enabled read/write lock for GitHubSanityCachedValue 2172

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED" locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@ravikumar2026 ravikumar2026 marked this pull request as draft February 22, 2026 03:31
@ravikumar2026 ravikumar2026 marked this pull request as ready for review February 27, 2026 22:46
@ravikumar2026 ravikumar2026 reopened this Feb 27, 2026
@codecov

codecov Bot commented Feb 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.41%. Comparing base (c67e401) to head (7ef707d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2201      +/-   ##
============================================
+ Coverage     85.38%   85.41%   +0.03%     
- Complexity     2566     2568       +2     
============================================
  Files           242      242              
  Lines          7572     7576       +4     
  Branches        398      399       +1     
============================================
+ Hits           6465     6471       +6     
+ Misses          870      869       -1     
+ Partials        237      236       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ravikumar2026

Copy link
Copy Markdown
Contributor Author

@bitwiseman Can you please review this as well. Thanks for reviewing PRs.

@bitwiseman bitwiseman force-pushed the feature/enableLock branch from 344a8fc to 7ef707d Compare July 11, 2026 22:59
@bitwiseman bitwiseman merged commit 79e0fc6 into hub4j:main Jul 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHubSanityCachedValue can block whole application

3 participants