Skip to content

Fix: log_error respects --quiet flag when stdout is redirected #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinayK34 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: log_error respects --quiet flag when stdout is redirected #1992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions httpie/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class LogLevel(str, Enum):
LogLevel.ERROR: GenericColor.RED,
}


LOG_LEVEL_DISPLAY_THRESHOLDS = {
LogLevel.INFO: 1,
LogLevel.WARNING: 2,
Expand Down Expand Up @@ -168,7 +169,9 @@ def as_silent(self) -> Iterator[None]:
self.stderr = original_stderr

def log_error(self, msg: str, level: LogLevel = LogLevel.ERROR) -> None:
if self.stdout_isatty and self.quiet >= LOG_LEVEL_DISPLAY_THRESHOLDS[level]:
# FIXED: Removed self.stdout_isatty from condition
# This ensures that the quiet flag works correctly even when stdout is redirected
if self.quiet >= LOG_LEVEL_DISPLAY_THRESHOLDS[level]:
stderr = self.stderr # Not directly /dev/null, since stderr might be mocked
else:
stderr = self._orig_stderr
Expand Down Expand Up @@ -214,4 +217,4 @@ def rich_console(self):

@cached_property
def rich_error_console(self):
return self._make_rich_console(self.stderr, self.stderr_isatty)
return self._make_rich_console(self.stderr, self.stderr_isatty)
Loading