feat: adopt html2rss default HTTPX strategy and WebMock adapter - #1138
Merged
Conversation
- Point Gemfile to sibling html2rss path for httpx experiment - Configure VCR to hook into :webmock with HTTPX adapter in spec_helper - Update strategy display names for default, faraday, and httpx - Explicitly require net/http in error_classifier for Net::OpenTimeout/ReadTimeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts the new generic
:defaultstrategy powered by HTTPX fromhtml2rssand updates WebMock/VCR and error classification accordingly.Note
This PR is opened in Draft. Pending release of
html2rssgem with HTTPX, the Gemfile / Bundler dependencies reflect the experimental sibling integration.Highlights
webmockwith HTTPX support inspec_helper.rb./api/v1/strategiesto public strategies (defaultandbotasaurus), filtering out internal aliases.HTTPX::ConnectionError,HTTPX::TLSError, andHTTPX::TimeoutErrorto network error classification.Html2rss::RequestService::PrivateNetworkDeniedto 403FORBIDDENinErrorClassifier::SPECIAL_DECISIONS.Verification
bundle exec rspecpassed (345 examples, 0 failures).bundle exec rubocopclean (122 files inspected, 0 offenses).