chore(configs): migrate legacy faraday strategy declarations to default and update specs - #325
Merged
Merged
Conversation
…lt and update specs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strategy: faradaydeclarations to the default strategy (strategy: defaultomitted as default):canada.ca/en_stories.ymlecologie.gouv.fr/presse.ymlforskningsradet.no/en_news.ymlparks.vic.gov.au/news.ymlstandards.org.au/news.ymlunep-wcmc.org/en_news.ymlspec/support/botasaurus_fetch_configs.rbto includehkma.gov.hkandndl.go.jp.spec/support/shared_examples/config.yml_spec.rbto requireselectors.titleonly whenenhanceis not enabled (as enhance extracts title from article cards).Verification
make validate: 220 configs validated successfully.make test: 2,226 examples, 0 failures.