Skip to content

fix(compare): align expandSelection public override with JFace - #17

Merged
hsoliwal merged 1 commit into
masterfrom
m3/compare-expand-public-20261022
Oct 23, 2026
Merged

hsoliwal merged 1 commit into
masterfrom
m3/compare-expand-public-20261022

Conversation

@hsoliwal

Copy link
Copy Markdown
Owner

Tycho compiler failure

The assembled Eclipse SDK compiles JFace's AbstractTreeViewer.expandSelection() as public, but Eclipse Compare's DiffTreeViewer override was protected. This inherited method-visibility mismatch stopped org.eclipse.compare compilation.

Exact generated repair

One modifier in the existing DiffTreeViewer.java: protected void expandSelection() → public void expandSelection(). The selection/expansion body, original Java25 unnamed lambda elsewhere in the file, all API identities, native/JNI code and untouched module sources remain identical.

Mandatory recipe-first proof

Synexia canonical PR #13136, commit 1dbbeccd0cbadbaffd3e338bca0a8b34103f9414:

  • Java-AST meta recipe adds only an exact path, task crate and SHA-256 Java25 exception to the existing Synexia text engine.
  • Generated one-source receiver through that hash-sealed recipe.
  • Two JUnit suites 6/6 + 6/6 pass on Java21; drift/duplicate/missing, fixed point, source hash, unrelated-file tests.
  • Why exceptional: Java21 OpenRewrite parser cannot round-trip source's Java25 _ -> lambda; built-in access recipe produced no edit without Tycho symbol attribution. No generic Java-to-text bypass exists.

The full Eclipse Tycho Java25 build advanced beyond Compare. Its next stop was forked Javadoc fetching OSGi external URLs with an untrusted proxy CA; this is environment setup, not a Compare compiler failure. Receipt in docs/M3-SCALE/eclipse-compare-expand-20261022/.

Draft until full SDK packaging, API baseline, SWT/JFace/Compare GUI and native tests qualify.

Apply one-line generated Java25 source successor from exact SHA/crate-sealed Synexia recipe. Keep body, lambda syntax, API/native code untouched. Record full Eclipse reactor proof.
@hsoliwal
hsoliwal marked this pull request as ready for review October 23, 2026 01:06
@hsoliwal
hsoliwal merged commit e81dfa1 into master Oct 23, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant