Repository navigation
fix(compare): align expandSelection public override with JFace - #17
Merged
Merged
Conversation
Apply one-line generated Java25 source successor from exact SHA/crate-sealed Synexia recipe. Keep body, lambda syntax, API/native code untouched. Record full Eclipse reactor proof.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tycho compiler failure
The assembled Eclipse SDK compiles JFace's
AbstractTreeViewer.expandSelection()as public, but Eclipse Compare'sDiffTreeVieweroverride was protected. This inherited method-visibility mismatch stoppedorg.eclipse.comparecompilation.Exact generated repair
One modifier in the existing
DiffTreeViewer.java:protected void expandSelection()→public void expandSelection(). The selection/expansion body, original Java25 unnamed lambda elsewhere in the file, all API identities, native/JNI code and untouched module sources remain identical.Mandatory recipe-first proof
Synexia canonical PR #13136, commit
1dbbeccd0cbadbaffd3e338bca0a8b34103f9414:_ ->lambda; built-in access recipe produced no edit without Tycho symbol attribution. No generic Java-to-text bypass exists.The full Eclipse Tycho Java25 build advanced beyond Compare. Its next stop was forked Javadoc fetching OSGi external URLs with an untrusted proxy CA; this is environment setup, not a Compare compiler failure. Receipt in
docs/M3-SCALE/eclipse-compare-expand-20261022/.Draft until full SDK packaging, API baseline, SWT/JFace/Compare GUI and native tests qualify.