Skip to content

M3: use packed command registries and require the native JFace forwarding gate - #17

Merged
hsoliwal merged 1 commit into
masterfrom
m3/eclipse-runtime-forwarding-20261018
Oct 19, 2026
Merged

hsoliwal merged 1 commit into
masterfrom
m3/eclipse-runtime-forwarding-20261018

Conversation

@hsoliwal

Copy link
Copy Markdown
Owner

Why

Make the existing M3 command-storage implementation own the two private ID registries, and qualify the existing JFace-to-SWT tree forwarding with a required native gate.

Runtime and receiver changes

  • CommandManager.categoriesById and parameterTypesById use the existing five-class packed-map donor closure in an internal package. Public/protected class APIs, definition sets, identity listeners, weak help storage, and reentrant callback behavior remain the contract.
  • The donor requires Java 21; the Commands manifest, classpath and compiler settings are updated together.
  • Add M3TreeForwardingTest, register it with the viewer suite, add the required Jupiter condition import, and provide the m3-forwarding Maven profile.
  • Correct the existing virtual-tree fixture by giving the item being expanded one child before setting viewer input. Its original sibling domains, assertions and SetData budgets remain unchanged.
  • Include the actual existing OpenRewrite recipes and selected SDK source owners, scoped provenance, and exact original execution evidence. No Synexia runtime dependency is introduced.

There are 14 actual recipe-emitted receiver files: nine Commands outputs and five JFace/gate outputs. The remaining 232 files are the public source mirror and three receiver metadata files.

Executed qualification

Gate Result
Final JFace recipe/admission SDK 15 tests passed, zero failures/errors/skips
Final Commands shared-owner SDK compatibility 6 passed; all nine emitted outputs unchanged
Rules compatibility with the same final Text owner 5 passed; separate Platform receiver evidence
Commands behavior 12 baseline / 13 candidate tests passed
Commands production compilation All 79 baseline / 84 candidate sources compiled with javac and genuine ECJ under the recorded diagnostic policies
Commands public/protected class APIs All 83 pre-existing class APIs equal
Commands real Equinox probe 8,211 assertion checks passed
Required native JFace method 1 passed, zero failures/errors/skips
Existing native report verifier Accepted the exact passing Surefire XML, exit 0

The native run used genuine GTK3/JNI and Xvfb, 546 SWT plus 423 JFace production sources, and the candidate Commands bundle. SWT production used JDK 21 with release 21; JFace production used JDK 25 with release 21. The native test hierarchy used JDK 25 with release 25 and ran on Java 25.

The original native failure is preserved. It established that the fixture expected a leaf to be expanded; only that fixture was corrected between the recorded failing and passing run. Production classes, dependency bytes, assertions, and the sibling-work budget were unchanged.

The proposed broader handleObjectsById replacement failed the recorded reentrant-order discriminator and is excluded. The two selected registries retain zero per-entry structural nodes in the 4,096-entry probe, compared with 4,096 in each baseline registry; this is not a throughput or total-heap claim.

Rewrites and review boundaries

Java postimages are parsed through the existing Java owner. Metadata uses exact whole-file hashes; the one Java 25 fixture bootstrap is sealed to its exact crate, path and before/after hashes and is qualified by its actual compilation and native execution. This change adds no general regex name substitution.

The 246-path publication was read back against exact local blob identities. Full whitespace checking retains 194 inherited findings in 21 original license/raw-evidence files. All three authored receiver metadata files, all 14 generated outputs, and the other 225 paths pass.

These are the committed bounded execution records. Full Tycho/PDE reactor testing, the complete workbench, other native configurations, and migration of all Eclipse owners remain separate work.

Canonical source: https://github.com/hsoliwal/com.synexia/pull/12357
Platform Rules receiver: hsoliwal/eclipse.platform#14

Receiver and reproduction instructions: https://github.com/hsoliwal/eclipse.platform.ui/tree/52f64fe74beb3f8763cefd28651c5d5ab01d5d92/docs/M3-SCALE/runtime-forwarding-20261018

Use the existing M3 packed-map donor for two private CommandManager
registries and align Commands metadata with its Java 21 requirement.

Require the native tree-forwarding method and correct its existing leaf
fixture. Include exact SDK emissions, scoped source mirrors, and original
compiler, behavior, Equinox and native execution evidence.
@hsoliwal
hsoliwal marked this pull request as ready for review October 19, 2026 05:19
@hsoliwal
hsoliwal merged commit a6a12de into master Oct 19, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant