Repository navigation
M3: use packed command registries and require the native JFace forwarding gate - #17
Merged
Merged
Conversation
Use the existing M3 packed-map donor for two private CommandManager registries and align Commands metadata with its Java 21 requirement. Require the native tree-forwarding method and correct its existing leaf fixture. Include exact SDK emissions, scoped source mirrors, and original compiler, behavior, Equinox and native execution evidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Make the existing M3 command-storage implementation own the two private ID registries, and qualify the existing JFace-to-SWT tree forwarding with a required native gate.
Runtime and receiver changes
CommandManager.categoriesByIdandparameterTypesByIduse the existing five-class packed-map donor closure in an internal package. Public/protected class APIs, definition sets, identity listeners, weak help storage, and reentrant callback behavior remain the contract.M3TreeForwardingTest, register it with the viewer suite, add the required Jupiter condition import, and provide them3-forwardingMaven profile.There are 14 actual recipe-emitted receiver files: nine Commands outputs and five JFace/gate outputs. The remaining 232 files are the public source mirror and three receiver metadata files.
Executed qualification
The native run used genuine GTK3/JNI and Xvfb, 546 SWT plus 423 JFace production sources, and the candidate Commands bundle. SWT production used JDK 21 with release 21; JFace production used JDK 25 with release 21. The native test hierarchy used JDK 25 with release 25 and ran on Java 25.
The original native failure is preserved. It established that the fixture expected a leaf to be expanded; only that fixture was corrected between the recorded failing and passing run. Production classes, dependency bytes, assertions, and the sibling-work budget were unchanged.
The proposed broader
handleObjectsByIdreplacement failed the recorded reentrant-order discriminator and is excluded. The two selected registries retain zero per-entry structural nodes in the 4,096-entry probe, compared with 4,096 in each baseline registry; this is not a throughput or total-heap claim.Rewrites and review boundaries
Java postimages are parsed through the existing Java owner. Metadata uses exact whole-file hashes; the one Java 25 fixture bootstrap is sealed to its exact crate, path and before/after hashes and is qualified by its actual compilation and native execution. This change adds no general regex name substitution.
The 246-path publication was read back against exact local blob identities. Full whitespace checking retains 194 inherited findings in 21 original license/raw-evidence files. All three authored receiver metadata files, all 14 generated outputs, and the other 225 paths pass.
These are the committed bounded execution records. Full Tycho/PDE reactor testing, the complete workbench, other native configurations, and migration of all Eclipse owners remain separate work.
Canonical source: https://github.com/hsoliwal/com.synexia/pull/12357
Platform Rules receiver: hsoliwal/eclipse.platform#14
Receiver and reproduction instructions: https://github.com/hsoliwal/eclipse.platform.ui/tree/52f64fe74beb3f8763cefd28651c5d5ab01d5d92/docs/M3-SCALE/runtime-forwarding-20261018