Skip to content

[fp8]: Read detected local world size environment variable #6438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tandede wants to merge 1 commit into
base: main
Choose a base branch
from
+31 −1
Open

[fp8]: Read detected local world size environment variable #6438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion colossalai/quantization/fp8.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ def process_group_is_intranode(pg):
local_world_size = None
for var in ["LOCAL_WORLD_SIZE", "OMPI_COMM_WORLD_LOCAL_SIZE", "SLURM_TASKS_PER_NODE"]:
if var in os.environ:
local_world_size = int(os.environ["LOCAL_WORLD_SIZE"])
local_world_size = int(os.environ[var])
break
if local_world_size is None:
local_world_size = torch.cuda.device_count()

Expand Down
29 changes: 29 additions & 0 deletions tests/test_fp8/test_fp8_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import pytest

from colossalai.quantization import fp8


@pytest.mark.parametrize(
"local_world_size_var",
["LOCAL_WORLD_SIZE", "OMPI_COMM_WORLD_LOCAL_SIZE", "SLURM_TASKS_PER_NODE"],
)
@pytest.mark.parametrize(
"group_ranks, expected",
[([0, 1, 2, 3], True), ([0, 1, 4, 5], False)],
)
def test_process_group_is_intranode(monkeypatch, local_world_size_var, group_ranks, expected):
for var in ["LOCAL_WORLD_SIZE", "OMPI_COMM_WORLD_LOCAL_SIZE", "SLURM_TASKS_PER_NODE"]:
monkeypatch.delenv(var, raising=False)
monkeypatch.setenv(local_world_size_var, "4")
monkeypatch.setattr(fp8.dist, "get_process_group_ranks", lambda _: group_ranks)

assert fp8.process_group_is_intranode(object()) is expected


def test_process_group_is_intranode_prefers_torchrun_local_world_size(monkeypatch):
monkeypatch.setenv("LOCAL_WORLD_SIZE", "4")
monkeypatch.setenv("OMPI_COMM_WORLD_LOCAL_SIZE", "2")
monkeypatch.setenv("SLURM_TASKS_PER_NODE", "1")
monkeypatch.setattr(fp8.dist, "get_process_group_ranks", lambda _: [0, 3])

assert fp8.process_group_is_intranode(object()) is True