Skip to content

Fix reusable CI workflow container schema for GitHub Actions linting #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into from
Draft

Fix reusable CI workflow container schema for GitHub Actions linting #525

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dc0edb
chore(deps): bump the github-actions-dependencies group across 1 dire…
dependabot[bot] Sep 4, 2026
64ea440
Fix CI workflow container lint schema
Copilot Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 25 additions & 15 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,16 +190,14 @@ jobs:
container-image: ${{ steps.parse.outputs.container-image }}
container-env: ${{ steps.parse.outputs.container-env }}
container-options: ${{ steps.parse.outputs.container-options }}
container-ports: ${{ steps.parse.outputs.container-ports }}
container-volumes: ${{ steps.parse.outputs.container-volumes }}
container-username: ${{ steps.parse.outputs.container-username }}
path-mapping: ${{ steps.parse.outputs.path-mapping }}
steps:
- id: parse
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
env:
CONTAINER_INPUT: ${{ inputs.container }}
CONTAINER_PASSWORD: ${{ secrets.container-password }}
CONTAINER_PASSWORD: ${{ secrets.container-password }} # zizmor: ignore[secrets-outside-env] reusable workflow validates private registry credentials before job container startup
WORKING_DIRECTORY: ${{ inputs.working-directory }}
with:
script: |
Expand Down Expand Up @@ -255,16 +253,28 @@ jobs:
core.setOutput('container-env', JSON.stringify(container.env));
}

if (container.options) {
core.setOutput('container-options', container.options);
}

if (container.ports) {
core.setOutput('container-ports', JSON.stringify(container.ports));
if (!Array.isArray(container.ports)) {
return core.setFailed('Container ports must be an array.');
}

container.options = [container.options, ...container.ports.map(port => `--publish ${port}`)]
.filter(Boolean)
.join(' ');
}

if (container.volumes) {
core.setOutput('container-volumes', JSON.stringify(container.volumes));
if (!Array.isArray(container.volumes)) {
return core.setFailed('Container volumes must be an array.');
}

container.options = [container.options, ...container.volumes.map(volume => `--volume ${volume}`)]
.filter(Boolean)
.join(' ');
}

if (container.options) {
core.setOutput('container-options', container.options);
}

if (container.credentials?.username) {
Expand Down Expand Up @@ -318,12 +328,12 @@ jobs:
contents: read
packages: read
container: &ci-container
image: ${{ needs.prepare.outputs.container-image || '' }}
image: ${{ needs.prepare.outputs.container-image || '' }} # zizmor: ignore[unpinned-images] reusable workflow intentionally accepts caller-provided container images
env: ${{ fromJSON(needs.prepare.outputs.container-env || '{}') }}
options: ${{ needs.prepare.outputs.container-options || ' ' }}
ports: ${{ fromJSON(needs.prepare.outputs.container-ports || '[]') }}
volumes: ${{ fromJSON(needs.prepare.outputs.container-volumes || '[]') }}
credentials: ${{ fromJSON(needs.prepare.outputs.container-username && format('{{"username":{0},"password":{1}}}',toJSON(needs.prepare.outputs.container-username),toJSON(secrets.container-password)) || '{}') }}
credentials:
username: ${{ needs.prepare.outputs.container-username || '' }}
password: ${{ secrets.container-password || '' }} # zizmor: ignore[secrets-outside-env] private registry container authentication is configured at the job container level
outputs:
working-directory: ${{ steps.working-directory.outputs.absolute-path }}
build-env: ${{ steps.build-variables.outputs.env }}
Expand Down Expand Up @@ -508,7 +518,7 @@ jobs:
with:
container: ${{ inputs.container != '' && 'true' || 'false' }}
working-directory: ${{ needs.setup.outputs.working-directory }}
build-secrets: ${{ secrets.build-secrets }}
build-secrets: ${{ secrets.build-secrets }} # zizmor: ignore[secrets-outside-env] build secrets are intentionally forwarded to the build action
build-commands: ${{ needs.setup.outputs.build-commands }}
build-env: ${{ needs.setup.outputs.build-env }}
build-artifact: ${{ needs.setup.outputs.build-artifact }}
Expand Down Expand Up @@ -577,4 +587,4 @@ jobs:
coverage: ${{ steps.prepare-test-options.outputs.coverage }}
report-file: ${{ steps.prepare-test-options.outputs.report-file }}
path-mapping: ${{ needs.prepare.outputs.path-mapping || '' }}
github-token: ${{ secrets.github-token || github.token }}
github-token: ${{ secrets.github-token || github.token }} # zizmor: ignore[secrets-outside-env] reusable workflow token override is intentional
Loading