feat(databases): add search parameter to list endpoint - #101
Merged
Conversation
hotdata-automation
Bot
requested review from
eddietejeda
and removed request for
a team
July 24, 2026 06:42
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review
Blocking Issues
-
The regenerated
list_databasesinsrc/apis/databases_api.rsnow takes a 4th positional parameter (search), but the hand-written wrapper and tests still call it with 3 arguments, so the crate no longer compiles:src/resources.rs:264(Databases::list)tests/common/mod.rs:187tests/databases_lifecycle.rs:26
Rust has no default arguments, so each is a hard compile error.
Action Required
- Regenerate/update
src/resources.rssoDatabases::listforwards the newsearchparameter tolist_databases. - Update the test call sites (
tests/common/mod.rs,tests/databases_lifecycle.rs) to pass the additionalsearchargument. - Verify
cargo buildandcargo testpass before merge.
Codegen added the search parameter to the generated list_databases, but the hand-written Databases::list wrapper and its callers still used the old arity, breaking the build (E0061). Thread search through the wrapper and update the example/test call sites.
Contributor
There was a problem hiding this comment.
Cycle 1 blocking issue resolved: the search parameter is now forwarded through the Databases::list wrapper (src/resources.rs) and all call sites (examples/quickstart.rs, tests/common/mod.rs, tests/databases_lifecycle.rs) pass the extra argument. Signatures are consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated from the updated HotData OpenAPI spec.
Source: https://github.com/hotdata-dev/www.hotdata.dev/pull/278