-
Notifications
You must be signed in to change notification settings - Fork 0
docs(changelog): restore pagination entry for list endpoint #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -12,6 +12,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||||||||||||||||||||||||
| - chore(query-runs): clarify user_public_id documentation | ||||||||||||||||||||||||||
| - feat(databases): add search parameter to list endpoint | ||||||||||||||||||||||||||
| - chore(databases): make pagination fields nullable | ||||||||||||||||||||||||||
| - feat(databases): add pagination support to list endpoint. | ||||||||||||||||||||||||||
| `DatabasesApi.list_databases` gains `limit` and `cursor`, and the response | ||||||||||||||||||||||||||
| gains `count`, `has_more`, and `next_cursor`. Note the behavior change: a call | ||||||||||||||||||||||||||
| with no `limit` now returns a single page rather than every database, so | ||||||||||||||||||||||||||
| callers that relied on one call seeing everything should follow `next_cursor` | ||||||||||||||||||||||||||
| while `has_more` is true. | ||||||||||||||||||||||||||
|
Comment on lines
+15
to
+20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: this entry describes a behavior break for existing callers (a no-
Suggested change
|
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| ### Removed | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nit:
ListDatabasesResponsealso gained alimitfield ("Page size applied to this response (after clamping to the maximum)"), which isn't listed here. Worth including so the entry matchesdocs/ListDatabasesResponse.md. (not blocking)