Skip to content

chore: remove files endpoints in favor of uploads - #145

Merged
hotdata-automation[bot] merged 2 commits into
mainfrom
openapi-update-29849344354
Jul 21, 2026
Merged

chore: remove files endpoints in favor of uploads#145
hotdata-automation[bot] merged 2 commits into
mainfrom
openapi-update-29849344354

Conversation

@hotdata-automation

Copy link
Copy Markdown
Contributor

Auto-generated from the updated HotData OpenAPI spec.
Source: https://github.com/hotdata-dev/www.hotdata.dev/pull/270

@hotdata-automation
hotdata-automation Bot requested a review from a team as a code owner July 21, 2026 16:37
@hotdata-automation
hotdata-automation Bot requested review from anoop-narang and removed request for a team July 21, 2026 16:37
@hotdata-automation
hotdata-automation Bot enabled auto-merge (squash) July 21, 2026 16:37

from pydantic import Field, StrictBytes, StrictStr
from typing import Optional, Tuple, Union
from pydantic import Field, StrictStr

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: This PR removes the generated upload_file / _upload_file_serialize op and the UploadResponse model, but the hand-written wrapper hotdata/uploads.py (not regenerated here) still depends on both:

  • hotdata/uploads.py:73 — module-level from hotdata.models.upload_response import UploadResponse. That module is deleted by this PR, so import hotdata now raises ModuleNotFoundError (hotdata/__init__.py:332 imports from hotdata.uploads import UploadsApi). The entire package fails to import.
  • hotdata/uploads.py:1183 and :1208 call self._upload_file_serialize(...), which this PR removed from the generated UploadsApi, so upload_stream() would raise AttributeError even if the import were fixed.

The hand-written legacy POST /v1/files fallback (upload_stream, _UPLOAD_FILE_RESPONSE_TYPES, the UploadResponse import) and the README section documenting it (README.md:159-165) must be updated in the same change that removes the generated endpoints — otherwise the SDK is unimportable.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — Blocking Issues

The package no longer imports. This auto-generated PR removes the POST/GET /v1/files endpoints and their models (UploadResponse, UploadInfo, ListUploadsResponse) plus the generated upload_file / list_uploads ops and _upload_file_serialize. But the hand-written wrapper hotdata/uploads.py — which is not regenerated and not part of this diff — still depends on the deleted code:

  • hotdata/uploads.py:73 has a module-level from hotdata.models.upload_response import UploadResponse. Since hotdata/init.py:332 does from hotdata.uploads import UploadsApi, import hotdata now fails with ModuleNotFoundError: No module named hotdata.models.upload_response.
  • hotdata/uploads.py:1183 and :1208 call self._upload_file_serialize(...), which was removed from the generated UploadsApi; upload_stream() would raise AttributeError.

Action Required — update the hand-written layer in the same change that drops the generated endpoints:

  • Remove (or rework) the legacy POST /v1/files fallback in hotdata/uploads.py: the UploadResponse import, _UPLOAD_FILE_RESPONSE_TYPES, and the upload_stream method that relies on _upload_file_serialize.
  • Update the README section documenting upload_stream / POST /v1/files (README.md:159-165) and the CHANGELOG entry referencing the legacy endpoint.
  • Confirm import hotdata succeeds and the test suite passes before merge.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior blocking issue resolved: the deleted UploadResponse model, _upload_file_serialize/upload_stream legacy fallback, and the README /v1/files section are all removed, and hotdata/uploads.py now imports only existing symbols. Package-wide grep confirms no dangling references. LGTM.

@hotdata-automation
hotdata-automation Bot merged commit e2ab0aa into main Jul 21, 2026
5 checks passed
@hotdata-automation
hotdata-automation Bot deleted the openapi-update-29849344354 branch July 21, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant