feat: delegate upload_parquet to SDK upload_file; classify 501 as terminal (0.7.3) - #48
Merged
Merged
Conversation
eddietejeda
enabled auto-merge (squash)
July 16, 2026 05:20
…minal (0.7.3) upload_parquet now uses hotdata.uploads.UploadsApi.upload_file (the enriched wrapper, not the generated class): concurrent part PUTs under a peak-memory budget, per-part retries, and ETag/size validation — large uploads are substantially faster than the old sequential loop. Errors re-raise with the underlying ApiException as direct cause so retry classification keeps seeing status codes — and 501 is now terminal there, not transient.
eddietejeda
force-pushed
the
fix/501-terminal-and-sdk-upload-delegation
branch
from
July 16, 2026 05:23
bd61d0a to
eed20a6
Compare
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Items 1 and 5 from the 0.7.2 code review (patches 2–4 subsumed by 5; no fallback or 501 special-casing — presigned uploads are always available on the server).
Changes
upload_parquet()is now a thin delegation tohotdata.uploads.UploadsApi.upload_file()(the enriched wrapper — the framework previously imported the bare generated class). Gains: concurrent part PUTs under a peak-memory budget, per-part retries, ETag/size validation, and substantially faster large uploads. Deletes the hand-rolled session→PUT→finalize flow, which also retires the review's ETag-KeyError, stale-Content-Length, and missing-size-check findings.classify_sdk_error: 501 → terminal (was transient via the 5xx bucket, burning retries on a permanent capability gap).UploadErrorchains re-raise with the underlyingApiExceptionas the direct cause, so retry classification keeps seeing status codes.Validation