refactor(e2e-ui): session guards on user command mounts - #173
Open
patrickleet wants to merge 1 commit into
Open
Conversation
Move session admission (has user / is admin) onto TypedRouteBuilder .guarded mounts so handlers only bind principal and call domain. Add CausalCommandContext::session, causal_has_user/causal_is_admin helpers, and keep input/domain checks in the handler body.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.guarded(causal_has_user, …)(andcausal_is_adminfor force-archive) instead of discovering missing identity mid-handler.principal(ctx)for domain owner/author args only; input parse, load, and domain invariants stay in the body.CausalCommandContext::session(); treat empty user id as missing foruser_id().Stack
Stacked on
tasks--contract-lifecycle-tooling-1(PR #172).Test plan
cargo check -p e2e-servicecargo test -p e2e-service --lib