Skip to content

fix(portal): show empty destination metrics - #1070

Merged
alexbouchardd merged 4 commits into
mainfrom
fix/list-metrics-loading-state
Sep 19, 2026
Merged

alexbouchardd merged 4 commits into
mainfrom
fix/list-metrics-loading-state

Conversation

@alexbouchardd

@alexbouchardd alexbouchardd commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • treat destinations omitted from a completed batched metrics response as an empty series
  • render six empty histogram samples with a 0 total instead of leaving the loading skeleton visible

Validation

  • npm run lint
  • npm run build
  • rendered the portal against the reported response shape with two zero-delivery destinations and one destination with 34 deliveries

Screenshot

Destination list showing six empty histogram samples for destinations with zero deliveries

Comment thread internal/portal/src/scenes/DestinationsList/DestinationEventsCell.tsx Outdated
@alexbouchardd
alexbouchardd merged commit 643714d into main Sep 19, 2026
4 checks passed
@alexbouchardd
alexbouchardd deleted the fix/list-metrics-loading-state branch September 19, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants