Repository navigation
test: unit-test the page-discovery helper in scripts/html-pages.mjs - #179
Merged
Merged
Conversation
htmlFiles(), isRedirectPage(), lineOf() and SKIP_DIRS decide which pages every static gate inspects, but nothing tested them directly: an over-broad SKIP_DIRS or a walker that stopped recursing would leave every gate green while it ran over fewer pages. Pin the walker on a throw-away tree, the redirect matcher on every attribute spelling, and the live tree against make-redirects.sh's MAP so the page set can never silently shrink. Closes #178 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
scripts/html-pages.test.mjs, a direct unit test forscripts/html-pages.mjs— the page-discovery helper that ten static gates import to decide which pages they inspect — and documents it in README## Checks(required byci-wiring.test.mjs).htmlFiles()on a temp tree: recursion, sorted output,.html-only, skips exactlySKIP_DIRS(any depth, directories only),[]on empty treeSKIP_DIRSpinned to the tooling set; never a content directoryisRedirectPage()positive spellings (quotes, case,=whitespace, attribute order, multi-line) and negatives (CSP / content-typehttp-equiv,name="refresh", prose)lineOf()1-based semanticsindex.html,404.html,stories/index.htmland everymake-redirects.shMAP page are discovered; nothing under a skipped dir is; redirect pages == MAP pathsMutation-verified: adding
"stories"toSKIP_DIRS, dropping the recursion, or loosening therefreshregex each fails 1–4 of the new cases while the existing 537 stay green. Full suite: 548/548,check-links.sh,check-redirects.test.sh,check-links.test.shall pass. Runs through the existingnode --test scripts/*.test.mjsstep — no workflow change.Closes #178
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88