Repository navigation
HQD-588: add a unit tree for request rate (RPS) prices - #6
Merged
Merged
Conversation
Add the rps tree: rps (base unit, factor 1) and krps (factor 1000), following the same shape as every other tree (bps, power, ...). There is no generator for units-tree.php, so it is hand-edited to match units-tree.yml. Add a float assertion to UnitTest covering 1500 rps = 1.5 krps - the existing assertConvert() helper only compares integer factors. Add UnitsTreeConsistencyTest to catch the yml/php trees drifting apart in the future, since nothing else enforces that they agree.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SilverFire
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
rpstree:rps(base unit, factor 1) andkrps(factor 1000), following the same shape as every other tree (bps,power, ...).There is no generator for
units-tree.php, so it is hand-edited to matchunits-tree.yml.UnitTestcovering1500 rps = 1.5 krps— the existingassertConvert()helper only compares integer factors.UnitsTreeConsistencyTestto catch the yml/php trees drifting apart in the future, since nothing else enforces that they agree.