Repository navigation
Require complete evidence finalization before reporting success - #15
Draft
hideouts-io wants to merge 1 commit into
Draft
hideouts-io wants to merge 1 commit into
hideouts-io wants to merge 1 commit into
Conversation
Publish the evidence manifest only after device metadata and complete checksums succeed. Propagate retained partial cases and incomplete outcomes through the CLI and UI journal. Repair the existing owned-command cancellation test fixture so its TERM trap runs before the test-controlled release under full-suite scheduling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Evidence collection could report completion after required device metadata, checksum, or manifest writing failed. The app journal could also record a finalized partial or failed case as succeeded.
Change
SHA256SUMS, reject unsafe checksum paths, and preserve verification of an empty export bundle.Verification
swift build --build-tests -j 4 -Xswiftc -warnings-as-errors --quiet— passed.swift test -j 4 -Xswiftc -warnings-as-errors --filter EvidenceFinalizationTests— 9 tests passed, using task-owned real filesystem cases.nice -n 10 swift test -j 4 -Xswiftc -warnings-as-errors --quiet— 275 tests passed after the fixture repair. The prior cancellation-test failure reproduced in an unchanged worktree and was traced to the shell fixture.nice -n 10 xcodebuild -quiet -project iOSDeveloperToolkit.xcodeproj -scheme iOSDeveloperToolkit -configuration Debug -destination 'platform=macOS,arch=arm64' -derivedDataPath /tmp/idt-evidence-finalization-20261027-derived -jobs 4 build-for-testing— passed; app and UI-test bundles compiled.SWIFT_TREAT_WARNINGS_AS_ERRORS=YESXcode override was attempted but stops in third-party SwiftNIO targets because-warnings-as-errorsconflicts with their-suppress-warningsflag. The project-configured app build above passed.Coverage and privacy
Native UI tests were not run locally while the desktop was in use. No physical device or user evidence was used or uploaded; tests used synthetic task-owned files. At exact head
f5281c6aa8d23984ca873341ef8d8193995a6445, hosted CI passed 275 Swift package tests, CLI smoke, app build, 16 UI tests, layout, real simulator, release packaging, and Dependency review. Swift CodeQL analysis and uploads passed without extraction diagnostics; it extracted all 78Sources/Swift files, 24/25 app files, and 3/27 test files, including all changed production Swift files. The limited test-file extraction is not a claim of complete Swift coverage. Native UI behavior on the owner desktop and physical acquisition/custody remain validation gates. This PR remains draft.