Skip to content

fix(lint): ignore audio clip start boundaries#2372

Closed
miguel-heygen wants to merge 1 commit into
mainfrom
fix/lint-ignore-audio-clip-boundaries
Closed

fix(lint): ignore audio clip start boundaries#2372
miguel-heygen wants to merge 1 commit into
mainfrom
fix/lint-ignore-audio-clip-boundaries

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

Summary

  • exclude <audio class="clip"> starts from visual scene-boundary detection
  • prevent unrelated SFX timing from triggering gsap_exit_missing_hard_kill
  • retain hard-kill enforcement at actual visual clip boundaries

Source feedback: https://heygen.slack.com/archives/C0BGC335AQY/p1783984033363839

Tests

  • bun run --filter @hyperframes/lint test -- src/rules/gsap.test.ts
  • bunx oxfmt --check packages/lint/src/rules/gsap.ts packages/lint/src/rules/gsap.test.ts
  • bunx oxlint packages/lint/src/rules/gsap.ts packages/lint/src/rules/gsap.test.ts
  • pre-commit typecheck

@miguel-heygen

Copy link
Copy Markdown
Collaborator Author

Closing in the owner-scoped backlog value sweep. This is a narrow lint/audit/docs/example/skills refinement, is currently conflicting, or adds more maintenance surface than its demonstrated user impact justifies. Reopen only if a current reproducible case makes it a priority again.

@WaterrrForever

Copy link
Copy Markdown
Collaborator

Same concern as #2371: this is a reproduction-backed lint false positive (<audio class="clip"> starts firing gsap_exit_missing_hard_kill), and lint errors gate users' builds. I checked #2413 — it touches gsap.ts but doesn't cover the audio-boundary case (no gsap_exit_missing_hard_kill changes in the diff). Could this ride along in #2413 since it's already consolidating lint/audit correctness? +23/-0 with tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants