fix(cli): respect transparent image pixels in occlusion audit#2367
Closed
miguel-heygen wants to merge 2 commits into
Closed
fix(cli): respect transparent image pixels in occlusion audit#2367miguel-heygen wants to merge 2 commits into
miguel-heygen wants to merge 2 commits into
Conversation
Collaborator
Author
|
Consolidated with the related layout and contrast audit fixes in #2401, which preserves this PR’s behavior and regression coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the layout occlusion audit sample the rendered alpha of
<img>pixels at each text probe point instead of treating every image rectangle as fully opaque. Preserve the conservative opaque fallback for unloaded or cross-origin images whose pixels cannot be read.Why
A full-screen transparent paper texture was reported as covering visibly unobstructed labels. The checker emitted
text_occludedbecause<img>elements were classified as opaque based only on their bounding box.Source report: https://heygen.slack.com/archives/C0BGC335AQY/p1783981645222299
How
object-fitandobject-positioninto source pixels.Test plan
Verified:
bun run --filter @hyperframes/cli test -- src/commands/layout-audit.browser.test.ts(52/52)bun run --filter @hyperframes/cli typecheckbunx oxlinton changed files