Repository navigation
Refactor/improve web frontend folder structure - #165
ChirayuBatra99 wants to merge 10 commits into
Conversation
|
src/lychd/public/_app/immutable/* looks like generated build output. Since it can be regenerated from the source code, I don’t think it should be committed. Could we remove it and add the path to .gitignore? |
|
I believe @zenithruneblade, has made a practice to push it. So I followed the same. |
|
@ChirayuBatra99 @Kiranchaudhary537 Thanks for raising this. Kiran, I agree that the generated frontend bundle should live in the wheel and container image. For this PR, please keep the generated assets tracked. The Containerfile currently copies the compiled Altar from the checkout, and CI checks that the committed output matches a fresh build. Let’s move bundle generation into packaging in a separate change. Once we’ve verified that the wheel and container image built from a clean checkout both serve Altar, we can remove the generated bundle from Git and add it to |
Summary
Reorganizes files into component folders and adds a reusable page header component.
Changes
Notes
Kiran's mentioned 2 points are not implemented yet, and will be done in future, once we have performed the basic level refactoring. The points were:
TL;DR