Skip to content

Refactor/improve web frontend folder structure - #165

Open
ChirayuBatra99 wants to merge 10 commits into
devfrom
refactor/improve-web-frontend-folder-structure
Open

ChirayuBatra99 wants to merge 10 commits into
devfrom
refactor/improve-web-frontend-folder-structure

Conversation

@ChirayuBatra99

@ChirayuBatra99 ChirayuBatra99 commented Nov 13, 2026 •

Copy link
Copy Markdown

Summary

Reorganizes files into component folders and adds a reusable page header component.

Changes

  • Moved files from a single flat directory into per-component folders
  • Added a reusable component for page headers.
  • Folder strcuture refactoring in the Scavenger component

Notes

Kiran's mentioned 2 points are not implemented yet, and will be done in future, once we have performed the basic level refactoring. The points were:

  • Keep assets in public folder for better caching
  • Having a proper service layer to isolate business logic.

TL;DR

  • Only refactoring of folders and relative imports. 0 code/logic/business logic changed in this PR.

@Kiranchaudhary537

Copy link
Copy Markdown

src/lychd/public/_app/immutable/* looks like generated build output. Since it can be regenerated from the source code, I don’t think it should be committed. Could we remove it and add the path to .gitignore?

@ChirayuBatra99

Copy link
Copy Markdown
Author

I believe @zenithruneblade, has made a practice to push it. So I followed the same.
What do you say @zenithruneblade , how shall we proceed?

Copy link
Copy Markdown
Contributor

@ChirayuBatra99 @Kiranchaudhary537 Thanks for raising this. Kiran, I agree that the generated frontend bundle should live in the wheel and container image. For this PR, please keep the generated assets tracked. The Containerfile currently copies the compiled Altar from the checkout, and CI checks that the committed output matches a fresh build.

Let’s move bundle generation into packaging in a separate change. Once we’ve verified that the wheel and container image built from a clean checkout both serve Altar, we can remove the generated bundle from Git and add it to .gitignore.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants