fix(uninstall): preserve release after pre-delete failure - #32628
Draft
loglapa wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Vladislav Lapin <51929896+loglapa@users.noreply.github.com>
pull-request-size
Bot
added
the
size/M
github-actions
Bot
added
the
v4.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Keeps a release deployed when a pre-delete hook fails instead of persisting it as uninstalling. The failed hook result is still recorded, so users can inspect the failure and either retry the uninstall or upgrade the release.
Closes #9700.
Special notes for your reviewer:
This preserves both recovery paths discussed on the earlier PR: retrying uninstall and upgrading the release. The change targets Helm v4 main; a v3 backport can be considered separately if still applicable.
Validation:
go test ./pkg/action -run '^TestUninstall' -count=1If applicable:
docs neededlabel should be applied if so)