Skip to content

Fix Ruby SDK silently swallowing API errors (SIGN-17019) #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adanilowski-dropbox merged 3 commits into from
Jul 22, 2026
Merged

Fix Ruby SDK silently swallowing API errors (SIGN-17019) #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82b7638
Fix Ruby SDK silently swallowing API errors (SIGN-17019)
adanilowski-dropbox Jul 21, 2026
85287e5
Do not commit test script
adanilowski-dropbox Jul 21, 2026
7441f8c
Add error handling spec for 5XX, timeout, and connection failures (SI…
adanilowski-dropbox Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions sdks/ruby/lib/dropbox-sign/api/account_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def account_create_with_http_info(account_create_request, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -123,6 +123,7 @@ def account_create_with_http_info(account_create_request, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -205,7 +206,7 @@ def account_get_with_http_info(opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -217,6 +218,7 @@ def account_get_with_http_info(opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -314,7 +316,7 @@ def account_update_with_http_info(account_update_request, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -326,6 +328,7 @@ def account_update_with_http_info(account_update_request, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -423,7 +426,7 @@ def account_verify_with_http_info(account_verify_request, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -435,6 +438,7 @@ def account_verify_with_http_info(account_verify_request, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down
13 changes: 9 additions & 4 deletions sdks/ruby/lib/dropbox-sign/api/api_app_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def api_app_create_with_http_info(api_app_create_request, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -123,6 +123,7 @@ def api_app_create_with_http_info(api_app_create_request, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -190,6 +191,7 @@ def api_app_delete_with_http_info(client_id, opts = {})
begin
data, status_code, headers = @api_client.call_api(:DELETE, local_var_path, new_options)
rescue Dropbox::Sign::ApiError => e
raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -272,7 +274,7 @@ def api_app_get_with_http_info(client_id, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -284,6 +286,7 @@ def api_app_get_with_http_info(client_id, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -366,7 +369,7 @@ def api_app_list_with_http_info(opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -378,6 +381,7 @@ def api_app_list_with_http_info(opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -481,7 +485,7 @@ def api_app_update_with_http_info(client_id, api_app_update_request, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -493,6 +497,7 @@ def api_app_update_with_http_info(client_id, api_app_update_request, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down
6 changes: 4 additions & 2 deletions sdks/ruby/lib/dropbox-sign/api/bulk_send_job_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def bulk_send_job_get_with_http_info(bulk_send_job_id, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -114,6 +114,7 @@ def bulk_send_job_get_with_http_info(bulk_send_job_id, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -196,7 +197,7 @@ def bulk_send_job_list_with_http_info(opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -208,6 +209,7 @@ def bulk_send_job_list_with_http_info(opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down
6 changes: 4 additions & 2 deletions sdks/ruby/lib/dropbox-sign/api/embedded_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def embedded_edit_url_with_http_info(template_id, embedded_edit_url_request, opt
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -129,6 +129,7 @@ def embedded_edit_url_with_http_info(template_id, embedded_edit_url_request, opt
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -211,7 +212,7 @@ def embedded_sign_url_with_http_info(signature_id, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -223,6 +224,7 @@ def embedded_sign_url_with_http_info(signature_id, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down
13 changes: 9 additions & 4 deletions sdks/ruby/lib/dropbox-sign/api/fax_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ def fax_delete_with_http_info(fax_id, opts = {})
begin
data, status_code, headers = @api_client.call_api(:DELETE, local_var_path, new_options)
rescue Dropbox::Sign::ApiError => e
raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -163,7 +164,7 @@ def fax_files_with_http_info(fax_id, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -175,6 +176,7 @@ def fax_files_with_http_info(fax_id, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -257,7 +259,7 @@ def fax_get_with_http_info(fax_id, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -269,6 +271,7 @@ def fax_get_with_http_info(fax_id, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -363,7 +366,7 @@ def fax_list_with_http_info(opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -375,6 +378,7 @@ def fax_list_with_http_info(opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -472,7 +476,7 @@ def fax_send_with_http_info(fax_send_request, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -484,6 +488,7 @@ def fax_send_with_http_info(fax_send_request, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down
19 changes: 13 additions & 6 deletions sdks/ruby/lib/dropbox-sign/api/fax_line_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def fax_line_add_user_with_http_info(fax_line_add_user_request, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -123,6 +123,7 @@ def fax_line_add_user_with_http_info(fax_line_add_user_request, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -228,7 +229,7 @@ def fax_line_area_code_get_with_http_info(country, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -240,6 +241,7 @@ def fax_line_area_code_get_with_http_info(country, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -337,7 +339,7 @@ def fax_line_create_with_http_info(fax_line_create_request, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -349,6 +351,7 @@ def fax_line_create_with_http_info(fax_line_create_request, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -431,6 +434,7 @@ def fax_line_delete_with_http_info(fax_line_delete_request, opts = {})
begin
data, status_code, headers = @api_client.call_api(:DELETE, local_var_path, new_options)
rescue Dropbox::Sign::ApiError => e
raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -514,7 +518,7 @@ def fax_line_get_with_http_info(number, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -526,6 +530,7 @@ def fax_line_get_with_http_info(number, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -614,7 +619,7 @@ def fax_line_list_with_http_info(opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -626,6 +631,7 @@ def fax_line_list_with_http_info(opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down Expand Up @@ -723,7 +729,7 @@ def fax_line_remove_user_with_http_info(fax_line_remove_user_request, opts = {})
range_code = "4XX".split('').first
range_code_left = "#{range_code}00".to_i
range_code_right = "#{range_code}99".to_i
if e.code >= range_code_left && e.code <= range_code_right
if e.code && e.code >= range_code_left && e.code <= range_code_right
body = @api_client.convert_to_type(
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
"Dropbox::Sign::ErrorResponse"
Expand All @@ -735,6 +741,7 @@ def fax_line_remove_user_with_http_info(fax_line_remove_user_request, opts = {})
e.message
end

raise e
end

if @api_client.config.debugging
Expand Down
Loading
Loading