Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

AllowDecline on TemplateSignatureRequest class is not translated into actual request (Status: Ready for Merge) #113

Description

@andre-engelbrecht

Problem description:

The TemplateSignatureRequest class has a boolean property for AllowDecline, but in the CreateUnclaimedDraft method, this property is not added to the actual request to HelloSign's API, and thus has no effect.

Steps to reproduce:

Create a new (embedded) signature request using the CreateUnclaimedDraft method with AllowDecline = true. When you try to sign this request using the generated URL, there is no option to decline.

SDK Version

1.3.0 - there is no newer version available.

Solution to resolve

Add the following code to the CreateUnclaimedDraft method

if (signatureRequest.AllowDecline)
{
    restRequest.AddParameter("allow_decline", "1");
}

Status

Ready for Merge
Link to PR: #114

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    legacyRelated to legacy, non-OpenAPI SDK

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions