Conversation
…353) GithubPullRequestApproved (#345) chega no onboarding via listener novo: resolve o autor via ExternalIdentity (provider github), confere se o repo aprovado é purpose=challenge e conclui o step git_challenge quando o onboarding Squads está parado exatamente nele, liberando o APTO. Aprovação em repo que não é de desafio é ignorada. GitChallengeDTO fecha o contrato pros campos do PR aprovado (repo, pr_number, approved_at), no lugar do payload livre que só existia como placeholder.
6 tasks
Pantotone
approved these changes
Sep 22, 2026
|
LGTM! Brilha moleque!! |
henrique-leme
approved these changes
Sep 22, 2026
gvieira18
approved these changes
Sep 22, 2026
fernanduandrade
approved these changes
Sep 22, 2026
cherryramatisdev
approved these changes
Sep 22, 2026
| { | ||
| $this->loadMigrationsFrom(__DIR__.'/../database/migrations'); | ||
|
|
||
| Event::listen(GithubPullRequestApproved::class, [CompleteGitChallengeOnPullRequestApproval::class, 'handle']); |
Member
There was a problem hiding this comment.
Se não me engano o InterNACHI consegue encontrar o evento.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
O step git_challenge do onboarding Squads conclui quando um revisor aprova, no GitHub, o PR do candidato num repo de desafio. O integration-github já emite o evento GithubPullRequestApproved. Esse PR entrega o listener que liga esse evento ao onboarding.
Alterações
Plano de Testes
Issues Relacionadas
Closes #353