feat(onboarding): implementa AdvanceStep com validacao via DTO#423
Merged
Conversation
5 tasks
guisaliba
reviewed
Jul 16, 2026
guisaliba
previously approved these changes
Jul 16, 2026
- adiciona stepDto ausente em SquadsOnboardingFlow (corrige fatal error por interface OnboardingFlow nao implementada) - corrige AdvanceStep: import de OnboardingStepStatus e chamada handler() - adiciona use statements faltantes em AdvanceStepTest
danielhe4rt
force-pushed
the
feat/346-welcome-advance-step
branch
from
July 18, 2026 21:03
3cc6db2 to
6b9aa00
Compare
- introduz contrato OnboardingStepDTO (validate/toArray de instancia) - stepDto() passa a retornar a instancia do contrato ao inves de class-string - remove a chamada estatica magica em AdvanceStep, agora polimorfica e tipada - WelcomeFormDTO implementa o contrato com guard defensivo no payload validado
danielhe4rt
approved these changes
Jul 18, 2026
gvieira18
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #346
O que foi feito
AdvanceStepque busca a etapa pendente, valida o payload e executa a transição.stepDtona interfaceOnboardingFlow. A responsabilidade de saber "como" validar os dados agora pertence ao fluxo específico.WelcomeFormDTO.WelcomeOnboardingFlowTest.phpcomprovando a mudança de status e geração docompleted_at.1. Estrutura do DTO (WelcomeFormDTO)
2. Testes e MultiTenancy
Eu já projetei os novos testes deste PR sem a injeção do Tenant, visando antecipar as mudanças do PR #421 que vai remover o multi-tenancy do projeto. Isso vai evitar conflitos e retrabalho futuro.