Repository navigation
Add explicit non-blocking reads for BufferedReader - #2144
Open
zhaojiale2021 wants to merge 1 commit into
Open
zhaojiale2021 wants to merge 1 commit into
zhaojiale2021 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the ambiguity around timeout=0 by providing BufferedReader.get_message_nowait(), backed by SimpleQueue.get(block=False).
The new method returns the oldest queued message or None without waiting, and remains compatible with the existing FIFO behavior. The docstring now points timeout-based callers to the explicit non-blocking API.
Validation: test/listener_test.py (11 tests passed).