Skip to content

Use 64-bit PCAN buffers only for acceptance filter parameters - #2143

Open
Solarboaters wants to merge 1 commit into
hardbyte:mainfrom
Solarboaters:fix/pcan-parameter-buffer-size
Open

Solarboaters wants to merge 1 commit into
hardbyte:mainfrom
Solarboaters:fix/pcan-parameter-buffer-size

Conversation

@Solarboaters

@Solarboaters Solarboaters commented Nov 18, 2026 •

Copy link
Copy Markdown

Fixes #2141. Repeat the Parameter comparison in both GetValue and SetValue so only the two acceptance-filter parameters use an eight-byte buffer; ordinary integer parameters use four bytes. String handling remains unchanged.

The regression exercises the real PCANBasic wrapper with a simulated driver, inspecting buffer sizes and reading/writing values. Six ordinary-parameter cases fail before; all 12 cases pass after, including both filter sizes with values above 32 bits and a string control. The focused PCAN suite passes 60 tests and 24 subtests. Combined with the configuration-source fix, 528 tests and 51 subtests pass, 107 skip and 32 UDP multicast cases are excluded. No driver/device test or claim that every PCAN driver rejects the previous size. AI-assisted implementation and testing.

The repository tox py environment also passes all 75 focused tests and 39 subtests (Python 3.12; extras limited to serial/canalystii/gs-usb). Full multi-version and hardware testing were not performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetValue: filter check is always true, so every parameter gets a 64-bit buffer

1 participant