Repository navigation
Use 64-bit PCAN buffers only for acceptance filter parameters - #2143
Open
Solarboaters wants to merge 1 commit into
Open
Solarboaters wants to merge 1 commit into
Solarboaters wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2141. Repeat the Parameter comparison in both GetValue and SetValue so only the two acceptance-filter parameters use an eight-byte buffer; ordinary integer parameters use four bytes. String handling remains unchanged.
The regression exercises the real PCANBasic wrapper with a simulated driver, inspecting buffer sizes and reading/writing values. Six ordinary-parameter cases fail before; all 12 cases pass after, including both filter sizes with values above 32 bits and a string control. The focused PCAN suite passes 60 tests and 24 subtests. Combined with the configuration-source fix, 528 tests and 51 subtests pass, 107 skip and 32 UDP multicast cases are excluded. No driver/device test or claim that every PCAN driver rejects the previous size. AI-assisted implementation and testing.
The repository tox py environment also passes all 75 focused tests and 39 subtests (Python 3.12; extras limited to serial/canalystii/gs-usb). Full multi-version and hardware testing were not performed.