Repository navigation
Preserve configuration sources when normalizing legacy keys - #2142
Open
Solarboaters wants to merge 1 commit into
Open
Solarboaters wants to merge 1 commit into
Solarboaters wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2140. Copy each configuration source before translating the legacy bustype key, so load_config() leaves caller-owned dictionaries and can.rc unchanged. Returned values, conversion and source precedence are preserved.
Regression tests cover argument, rc, environment and file dictionaries, repeated calls, existing/empty interface keys and precedence. Before the fix both added tests fail (including 12 source/interface subcases); afterward all 15 configuration/file tests and 15 subtests pass. The two batch changes together pass 528 tests and 51 subtests, with 107 skips and 32 UDP multicast cases excluded; these exclusions are not claimed as passes. No CAN hardware was used. AI-assisted implementation and testing.
The repository tox py environment also passes all 75 focused tests and 39 subtests (Python 3.12; extras limited to serial/canalystii/gs-usb). Full multi-version and hardware testing were not performed.