Repository navigation
Read classic and FD frame flags from CANFD ASC records - #2139
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
timothyanderson096-ocdealcheck wants to merge 1 commit into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ASC layout tagged
CANFDcan carry classical CAN data, classical remote requests, and CAN FD data. The reader treated every record as FD and zero payload length as a remote request. An empty FD message therefore failed to round-trip throughASCWriter, and a classical remote request in the existing Vector fixture was returned with incompatible flags.Read the FDF and RTR bits from the flags word and preserve the requested DLC for remote records. Keep the prior handling for logs without a readable flags field and the existing 64-byte fixture with an unset FD bit. This addresses the mixed-format case discussed in #997.
Five regression cases failed on main. The file-format, logger, message and rotating-logger tests passed locally on Python 3.12 (115 passed, 18 skipped, plus five subtests). An independent check covered 164 records produced by can-utils
log2asc -fand 1,312 generated ASC records. Ruff and Black passed. Tests used offline files.Prepared and tested with OpenAI Codex.
Timothy Anderson · Spotted Ridge Engineering / OC Labs · GDN (Global Decision Network)
timothyanderson096@gmail.com