Skip to content

Preserve requested lengths in candump remote frames - #2136

Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
hardbyte:mainfrom
timothyanderson096-ocdealcheck:fix/candump-remote-frame-dlc
Open

timothyanderson096-ocdealcheck wants to merge 1 commit into
hardbyte:mainfrom
timothyanderson096-ocdealcheck:fix/candump-remote-frame-dlc

Conversation

@timothyanderson096-ocdealcheck

Copy link
Copy Markdown
Contributor

Summary of Changes

Copying a candump log changed a remote frame from 123#R8 to 123#R. Reading the copy reported a requested length of zero. Preserve requested lengths 1 through 8 when writing classic remote frames. A zero-length request keeps the existing bare R spelling.

Related Issues / Pull Requests

The can-utils reference formatter defines the spelling for these frames.

Type of Change

  • Bug fix

Checklist

  • Added regression tests, documentation and a changelog fragment.
  • Verified against the current upstream base.
  • Full tox matrix.

Additional Notes

The length-five and length-eight test cases failed on the original code and pass with this change. The file-format suite passed 86 tests with 18 skips. A further 36 logger, message and rotating-logger tests passed. Pinned Ruff passed for the project and Black passed for both modified Python files.

Independent offline verification covered 240 remote-frame cases and 288 classical and FD data-frame controls using real log files.

Prepared and tested with OpenAI Codex.

Timothy Anderson · Spotted Ridge Engineering / OC Labs · GDN (Global Decision Network)
timothyanderson096@gmail.com · Engineering evidence

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-18T03:30:24.162734Z
We couldn’t complete this review. Comment @codex review to try again.
40db20b PR opened
🔒 Security Review ❌ Failed 2026-11-18T03:30:29.240713Z
We couldn’t complete this review. Comment @codex security review to try again.
40db20b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant