Repository navigation
Preserve requested lengths in candump remote frames - #2136
timothyanderson096-ocdealcheck wants to merge 1 commit into
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
Summary of Changes
Copying a candump log changed a remote frame from
123#R8to123#R. Reading the copy reported a requested length of zero. Preserve requested lengths 1 through 8 when writing classic remote frames. A zero-length request keeps the existing bareRspelling.Related Issues / Pull Requests
The can-utils reference formatter defines the spelling for these frames.
Type of Change
Checklist
Additional Notes
The length-five and length-eight test cases failed on the original code and pass with this change. The file-format suite passed 86 tests with 18 skips. A further 36 logger, message and rotating-logger tests passed. Pinned Ruff passed for the project and Black passed for both modified Python files.
Independent offline verification covered 240 remote-frame cases and 288 classical and FD data-frame controls using real log files.
Prepared and tested with OpenAI Codex.
Timothy Anderson · Spotted Ridge Engineering / OC Labs · GDN (Global Decision Network)
timothyanderson096@gmail.com · Engineering evidence