Repository navigation
Fix payload lengths when reading CAN FD and J1939 TRC logs - #2135
timothyanderson096-ocdealcheck wants to merge 1 commit into
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
Summary of Changes
The PEAK TRC 2.x reader returned a CAN FD length code as
Message.dlc, which python-can defines in bytes. A recorded 64-byte frame could therefore report 15 bytes. The lowercaselfield already contains bytes, including for long J1939 messages. For the uppercaseLfield, translate valid wire codes only on CAN FD records. Keep the existing interpretation of other record types.Related Issues / Pull Requests
The field definitions and worked examples are in the PEAK TRC file specification, pages 13 and 15–18.
Type of Change
Checklist
tox). The 28 local UDP multicast initialization failures also reproduced on pristine main.Additional Notes
Five new regression cases failed on main. In an offline TRC-to-BLF conversion, the fix preserved both the 64-byte payload and its reported length. On Linux CPython 3.14, the test suite excluding the unavailable multicast fixtures passed 529 tests and 36 subtests. The file-format suite, lint, configured type checks, strict docs and doctests, and packaging checks passed locally. No physical CAN interface was required for the file conversion.
Prepared and tested with OpenAI Codex.
Timothy Anderson · Spotted Ridge Engineering / OC Labs · GDN (Global Decision Network)
timothyanderson096@gmail.com · Engineering evidence