Repository navigation
fix(kvaser): pass unsigned integer for local TXACK - #2134
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
timothyanderson096-ocdealcheck wants to merge 1 commit into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
CANlib documents
canIOCTL_SET_LOCAL_TXACKas taking an unsigned integer, but the Kvaser constructor passes a one-byte buffer. Usectypes.c_uintand its native size. Preserve the existing TXECHO byte buffer and error propagation.Adds a constructor regression covering all four
single_handle/receive_own_messagescombinations and a news fragment. The vendor contract provides the independent expected type and size.Related Issues / Pull Requests
Related to #2050, #2051, #2079 and #1908. These reports include other ioctl failures; this change addresses only the TXACK argument contract and does not claim every reported hardware failure is resolved.
Type of Change
Checklist
doc/changelog.d/2050.fixed.rst.tox) — focused and configured static/docs results are below; full suite and hosted matrix remain unverified.Validation
Exact head
4d417b449d4c8926aacdbbc042eceb303011d6c1, based on current upstream2aec6d66d28c24559cc1961d901c864d2f5b9e4e. No source revision was needed during this refresh.Native CANlib, physical adapters, the full test suite and hosted OS/interpreter validation remain unverified. This is a vendor-contract regression, not a physical receiver reproduction.
Prepared with OpenAI Codex assistance and independent inspection.
Timothy Anderson — Spotted Ridge Engineering / OC Labs
Independent software verification · GDN (Global Decision Network)
timothyanderson096@gmail.com · Engineering evidence