Repository navigation
pcan: skip controller status messages on receive - #2133
Open
lizaolahoaglund wants to merge 1 commit into
Open
lizaolahoaglund wants to merge 1 commit into
lizaolahoaglund wants to merge 1 commit into
Conversation
PCAN-Basic can return PCAN_ERROR_OK with the PCAN_MESSAGE_STATUS bit set, for example when the CAN controller is activated. The ID and length fields in a status message do not describe a CAN frame. Skip status messages before constructing a Message. Continue reading queued frames while respecting the receive timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
PCAN-Basic can return
PCAN_ERROR_OKfor a controller status notification, for example when the controller is activated.PcanBus.recv()currently turns that notification into a CAN message, even though its ID and length don't describe a CAN frame.Skip entries marked
PCAN_MESSAGE_STATUSand keep reading within the receive timeout. The regression tests cover Classic CAN and CAN FD, including a data frame queued behind a status notification.PCAN-Basic status frame documentation
Type of Change
Checklist
toxon Windows.