Repository navigation
fix(mf4): defer asammdf imports until reader/writer construction - #2123
Open
timothyanderson096-ocdealcheck wants to merge 2 commits into
Open
timothyanderson096-ocdealcheck wants to merge 2 commits into
timothyanderson096-ocdealcheck wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Preserve UTC writer timestamps and packed error-frame decoding while retaining lazy asammdf imports. Adapt the upstream payload tests to use asammdf-owned helpers and keep runtime path annotations compatible with Sphinx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Importing
asammdffirst can re-entercanthroughcanmatrix/canopenbeforeasammdffinishes initializing. The optional-import guard then permanently treats an installed dependency as missing.Closes #2122. Thanks to @nehalkpatel for the reproduction and dependency-chain analysis.
Type of Change
Checklist
Current validation — 13 November 2026
Published revision
dcbe0e4394b7286aaa4326557b7bc8805348fd4fmerges upstream86e85794f6c3505c988a4acd5d34f5b08f508b17into the existing PR. Its complete treec2d30628aaaeff97d88042704a8a4e3e9d018f2fmatches the final locally verified tree.Environment: Linux / CPython 3.12.14; asammdf 8.7.2, canmatrix 1.2, canopen 2.4.1. The shallow checkout used a local setuptools-scm version override for installation.
_thread.allocate_lockreference also present on unchanged upstream. The introduced path-annotation reference warning was repaired; no warning suppression was added.No physical CAN hardware or minimum asammdf 6 validation is claimed. The historical local full-suite and strict HTML results above retain their stated limitations; successful hosted validation below is separate.
Hosted validation — checked 18 November 2026 (Brisbane)
Tests run 43397825677 completed successfully for the same published revision
dcbe0e4394b7286aaa4326557b7bc8805348fd4f. All 21 test-matrix jobs across Ubuntu, macOS and Windows (CPython 3.11–3.15 and PyPy 3.11–3.12), static code analysis, documentation, packaging and coverage aggregation succeeded. Release publication was skipped. These hosted results supersede the earlier pending-CI wording; no source change or new local rerun was needed for this status refresh.Prepared with OpenAI Codex assistance and independent inspection.
Timothy Anderson — Spotted Ridge Engineering / OC Labs
Independent software verification · GDN (Global Decision Network)
timothyanderson096@gmail.com · Engineering evidence