Skip to content

kubernetes-ingress: add crdjob enablement configuration - #379

Closed
duncan485 wants to merge 1 commit into
haproxytech:mainfrom
duncan485:main
Closed

kubernetes-ingress: add crdjob enablement configuration#379
duncan485 wants to merge 1 commit into
haproxytech:mainfrom
duncan485:main

Conversation

@duncan485

Copy link
Copy Markdown
Contributor

Make it possible to disable the crdjob, as some users will not need or want to use the crds.

@dkorunic

Copy link
Copy Markdown
Member

Sadly, this has to be rejected. We want to maintain a well-defined and consistent state in which the CRD job has always been run and the CRDs have always been upgraded to the latest version.

Introducing a toggle here could lead to inconsistent states and various issues that we specifically want to avoid for our users and customers.

@dkorunic dkorunic closed this Aug 28, 2026
@duncan485

Copy link
Copy Markdown
Contributor Author

What about configuring activeDeadlineSeconds in the job? Is that something I could add ?

@dkorunic

dkorunic commented Aug 28, 2026

Copy link
Copy Markdown
Member

The CRD upgrade should typically complete within a few seconds at most, so there is little to be gained from changing activeDeadlineSeconds. Could you explain your use case for adjusting this value?

@duncan485

Copy link
Copy Markdown
Contributor Author

I understand your question; we are seeing our argocd instance sometimes keep hanging indefinitely on the job. This might be verry specific to our environment, and most likely not the root cause But If we can set the activedeadline seconds we can at least limit the sympton

@dkorunic

Copy link
Copy Markdown
Member

I understand. Please send a PR for this, and I’ll get it merged and released as soon as possible.

@duncan485

Copy link
Copy Markdown
Contributor Author

Thanks @dkorunic I really appreciate that. The PR is here: #381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants