Skip to content

Add attachment upload from URL tool - #11

Merged
ruibaby merged 1 commit into
mainfrom
feat/upload-attachment-from-url
Sep 1, 2026
Merged

ruibaby merged 1 commit into
mainfrom
feat/upload-attachment-from-url

Conversation

@ruibaby

@ruibaby ruibaby commented Sep 1, 2026

Copy link
Copy Markdown
Member

Summary

  • add halo_upload_attachment_from_url for transferring remote files into the Halo attachment library
  • use the Console attachment policy and group without exposing storage configuration to MCP callers
  • accept an optional safe filename and return the resolved attachment permalink

Security

  • only accept absolute HTTP and HTTPS URLs
  • delegate SSRF protection, response-size limits, timeouts, and redirect handling to Halo's AttachmentService.uploadFromUrl

Testing

  • ./gradlew test --tests run.halo.mcpserver.tools.AttachmentToolsTest --tests run.halo.mcpserver.tools.BuiltInToolsTest --no-daemon
  • ./gradlew check --no-daemon
  • git diff --check

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-01T11:06:46.349969Z 98d0f16 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ruibaby
ruibaby merged commit 84d1e3e into main Sep 1, 2026
1 check passed
@ruibaby
ruibaby deleted the feat/upload-attachment-from-url branch September 1, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant