Add theme setting management tools - #10
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
# Conflicts: # src/test/java/run/halo/mcpserver/tools/BuiltInToolsTest.java
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f2733d3fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fc9a77262
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Updates the THEME category display label from “主题设置” to “主题” in `ui/src/utils/tool.ts`, and adjusts the corresponding unit test expectation to keep behavior and tests aligned.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53bef6fa9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| static final String GET_TEMPLATE = "halo_get_theme_template"; | ||
| static final int MAX_TEMPLATE_BYTES = 256 * 1024; | ||
| private static final int MAX_TEMPLATE_COUNT = 2_000; | ||
| private static final JsonMapper JSON_MAPPER = JsonMapper.shared(); |
There was a problem hiding this comment.
Preserve precision when parsing stored setting values
When a stored group contains a high-precision decimal such as 1.0000000000000000000001, this shared mapper parses it as a binary floating-point node because it does not enable USE_BIG_DECIMAL_FOR_FLOATS. Consequently, getGroup can return a rounded value, and updating an unrelated field serializes that rounded value back into the ConfigMap, corrupting the existing setting. Configure this mapper for decimal preservation as well, not only the protocol mapper.
Useful? React with 👍 / 👎.
What
0.Security
Validation
./gradlew check --no-daemon --console=plainCloses #9