Skip to content

Move frontend workspace into packages Gradle module - #255

Merged
ruibaby merged 2 commits into
mainfrom
chore/move-frontend-workspace
Sep 24, 2026
Merged

ruibaby merged 2 commits into
mainfrom
chore/move-frontend-workspace

Conversation

@ruibaby

@ruibaby ruibaby commented Sep 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Move the pnpm workspace and frontend tool configuration into packages/, and add it as a Gradle module.
  • Build frontend assets in package-local output directories and include them in the plugin JAR through processResources.
  • Update CI, npm release, and Husky paths for the new workspace root.

Validation

  • ./gradlew clean build with Java 21
  • pnpm install --frozen-lockfile from packages/
  • pnpm -C comment-widget test from packages/ — 128 tests passed
  • pnpm -C ui type-check from packages/
  • pnpm -C widget exec node --test tests/content-hash.test.mjs from packages/
  • pnpm exec biome check . from packages/ — 116 files checked
  • Confirmed the JAR contains ui/main.*.js, static/comment-widget.js, and static/index.css
  • Confirmed a subsequent :packages:pnpmBuild is up to date

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T15:24:38.968442Z b01c3c3 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ruibaby
ruibaby merged commit cf3ed7e into main Sep 24, 2026
2 checks passed
@ruibaby
ruibaby deleted the chore/move-frontend-workspace branch September 24, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant