Skip to content

Improve model selector with required-feature hints and management link - #113

Merged
ruibaby merged 2 commits into
mainfrom
improvement/model-selector-feature-hints
Sep 22, 2026
Merged

ruibaby merged 2 commits into
mainfrom
improvement/model-selector-feature-hints

Conversation

@ruibaby

@ruibaby ruibaby commented Sep 14, 2026 •

Copy link
Copy Markdown
Member

What

Improves the AI model selector guidance as requested in #112:

  • requiredFeatures no longer filters models out of the dropdown. All models matching the
    other criteria (e.g. modelType) are listed, and options missing required features stay
    selectable with an orange hint such as "当前模型不支持工具调用,可能无法正常使用".
  • Adds a "管理模型" footer link to the dropdown that navigates to the model management page,
    so users can quickly configure models when no suitable option is available.

The backend model-options API semantics are unchanged: requiredFeatures remains an all-of
filter for direct API consumers; only the selector component stops passing it and computes
missing features client-side.

Why

Previously, when no model satisfied requiredFeatures, the selector showed an empty state
("没有满足能力要求的模型") with no indication that models existed but lacked the required
features, leaving users without guidance.

Behavior change

The FormKit aiModelSelector requiredFeatures prop changes from a hard all-of filter to a
non-blocking hint, as explicitly requested in #112. This affects the Console settings forms of
consumer plugins using requiredFeatures: users of those plugins can now select and save a
model that lacks the declared features, so consumers that require a hard guarantee should
validate at runtime or switch to requiredCapabilities, which still filters. The backend
model-options API contract and persisted data are unchanged. Consumer documentation
(dev/en/model-selector.md, dev/zh-CN/model-selector.md, dev/zh-CN/dev.md) is updated in
this PR to describe the new semantics.

Validation

  • pnpm test:unit — 202 tests passed, including new coverage for the warning hint, the
    still-selectable behavior, and the footer link
  • pnpm type-check / pnpm lint — clean

Fixes #112

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-14T14:27:23.306876Z bcba27d New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b590e1b721

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui/src/formkit/AiModelSelector.vue

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bcba27d3e1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui/src/formkit/AiModelSelector.vue
@ruibaby
ruibaby requested a review from LIlGG September 20, 2026 09:26
@ruibaby
ruibaby merged commit ffb087c into main Sep 22, 2026
1 check passed
@ruibaby
ruibaby deleted the improvement/model-selector-feature-hints branch September 22, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

优化模型选择组件,提供更多引导

2 participants