Repository navigation
Improve model selector with required-feature hints and management link - #113
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b590e1b721
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcba27d3e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
What
Improves the AI model selector guidance as requested in #112:
requiredFeaturesno longer filters models out of the dropdown. All models matching theother criteria (e.g.
modelType) are listed, and options missing required features stayselectable with an orange hint such as "当前模型不支持工具调用,可能无法正常使用".
so users can quickly configure models when no suitable option is available.
The backend
model-optionsAPI semantics are unchanged:requiredFeaturesremains an all-offilter for direct API consumers; only the selector component stops passing it and computes
missing features client-side.
Why
Previously, when no model satisfied
requiredFeatures, the selector showed an empty state("没有满足能力要求的模型") with no indication that models existed but lacked the required
features, leaving users without guidance.
Behavior change
The FormKit
aiModelSelectorrequiredFeaturesprop changes from a hard all-of filter to anon-blocking hint, as explicitly requested in #112. This affects the Console settings forms of
consumer plugins using
requiredFeatures: users of those plugins can now select and save amodel that lacks the declared features, so consumers that require a hard guarantee should
validate at runtime or switch to
requiredCapabilities, which still filters. The backendmodel-optionsAPI contract and persisted data are unchanged. Consumer documentation(
dev/en/model-selector.md,dev/zh-CN/model-selector.md,dev/zh-CN/dev.md) is updated inthis PR to describe the new semantics.
Validation
pnpm test:unit— 202 tests passed, including new coverage for the warning hint, thestill-selectable behavior, and the footer link
pnpm type-check/pnpm lint— cleanFixes #112