feat(reviews): per-reviewer vote breakdown and travel yes rate on the leaderboard - #181
Merged
Merged
Conversation
…on the leaderboard
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The admin review leaderboard only showed a total
completedcount per reviewer. It now also shows how each person is deciding.GetLeaderboardadds moreCOUNT(ar.id) FILTER (...)aggregates to the existing query, exposed onstore.ReviewerStatsas raw counts (percentages are computed client-side):Ranking is unchanged (still by
completed).UI: new columns Accepted / Rejected / Waitlisted (share of that reviewer's completed with the raw count beside it,
67% (8), colored to matchVoteBadge) and Travel Yes (67% (4/6), or-when they have given no travel recommendations). Swagger regenerated; integration test now votes with mixed values and travel votes to cover each count.Link to Devin session: https://app.devin.ai/sessions/e747c0ba90254f8abe73db464417cb55
Open in Devin Desktop: https://app.devin.ai/desktop/session/e747c0ba90254f8abe73db464417cb55?variant=devin
Requested by: @balebbae