Skip to content

HCK-18434: comment out separate comment statements of deactivated columns and tables - #108

Merged
chulanovskyi-bs merged 1 commit into
developfrom
fix/HCK-18434
Nov 4, 2026
Merged

chulanovskyi-bs merged 1 commit into
developfrom
fix/HCK-18434

Conversation

@Sylvie-P

@Sylvie-P Sylvie-P commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Sub-bugHCK-18434 [Hive, Glue, Teradata] Separate comment statements of deactivated columns and tables are not commented out

## Content

HCK-18434: separate comment statements of deactivated columns and tables were not commented out.

Technical details

  • hydrateAlterColumns computes isActivated from the table flag (entity.role.isActivated) and the column flag, and provider.alterTableColumns comments the CHANGE ... COMMENT statement with commentDeactivatedStatements when it is false.
  • In generateModifyCollectionScript, the statements of a modified deactivated table (including SET TBLPROPERTIES ('comment'=...)) are commented.

Note for testers (Glue)

Glue does not use the same fields as Hive. This is expected (see HCK-8183):

  • Table and database: fill Description. That value becomes COMMENT in HiveQL and Description in AWS CLI.
  • Column: fill Comments. That value becomes COMMENT in HiveQL and Comment in AWS CLI.

Script generation options (inline / separate / ignore) apply only to the HiveQL script, not to AWS CLI.

Made with Cursor

…umns and tables

Co-authored-by: Cursor <cursoragent@cursor.com>
@Sylvie-P Sylvie-P self-assigned this Nov 4, 2026
@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

@chulanovskyi-bs
chulanovskyi-bs merged commit 122c937 into develop Nov 4, 2026
4 of 8 checks passed
@chulanovskyi-bs
chulanovskyi-bs deleted the fix/HCK-18434 branch November 4, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants